Do not handle shuffle twice #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'd love to help add a test against #382. Any advice on where to start? |
I ran against your file, of course. For a test in CI, you could resurrect #274, and build in some of these various compression/shuffle/encoding options. I don't really know how to make hdf files which would exercise all of the code paths in SingleHdf5ToZarr . |
|
But OK to merge and quick release here? |
|
Sure, we appreciate the quick fix! 🙏 We'll think about how to address the testing question, which is needed in order to guard against the same problem happening in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #382